Type as int64 #2576
Closed
Type as int64 #2576
+31
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A cmake error appeared on s390x. Patch is not involved. |
zherczeg
force-pushed
the
type_i64
branch
4 times, most recently
from
79b8de1 to
6ed1ecf
Compare
|
It looks like uvwasi is very old (Sun May 17 17:49:24 2020), but moving to a newer version does not help as well. |
|
I keep the branch for a while, but close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is on the top of #2572 and changes the Type internal representation to an i64. This way the reference types and their 32 bit indices can fit into a single value. In the future, the nullable references (e.g.
(ref func)/funcref) can be handled by the upper 32 bit.