Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposed binary format and initial prototype notes #1

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

tlively
Copy link
Member

@tlively tlively commented Feb 19, 2025

With the intent to make the proposal concrete enough to implement.

With the intent to make the proposal concrete enough to implement.
@tlively tlively requested a review from rossberg February 19, 2025 00:59
@tlively
Copy link
Member Author

tlively commented Feb 19, 2025

cc @jakobkummerow.

I'm going to go ahead and merge this, but @rossberg, I would appreciate if you could take a look and provide any feedback on the proposed factoring of the syntax and binary format. Specifically, I add descriptor and describes clauses as prefixes of comptype just like we do with shared in the shared-everything threads proposal. Does that sound right to you?

@tlively tlively merged commit 351de2d into main Feb 19, 2025
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me. The only part that doesn’t seem right is the placement of descriptor clauses outside the shared clause. Sharedness “scopes over” the descriptor clauses, i.e., in a shared type, the descriptor and describee must be shared as well. I think the syntactic structure needs to reflect that.

Another bikeshedding comment is that I would replace the _rtt suffix in the new instructions with _desc. First, because that matches the terminology of the declaration clauses. And second, because descriptors are not actually RTTs, they merely carry them, plus arbitrary other stuff.

@tlively
Copy link
Member Author

tlively commented Feb 19, 2025

Thanks, @rossberg! These adjustments (and fixing the text format in the examples) is done in #3 and #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants