Initial commit #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed
learyjk
reviewed
Nov 7, 2023
src/01-1-basics.js
Outdated
| } | ||
|
|
||
| function countByTwos() { | ||
| // 2. Using a while loop, log even numbers from 2 to 20. | ||
| let i = 2; | ||
| while (i <= 2) { | ||
| console.log(i) |
There was a problem hiding this comment.
you need to increment i here something like i+=2
right now you have an 'infinite loop' scenario which causes the remote testing to fail!
src/01-1-basics.js
Outdated
| // Your code here | ||
| if (length * width < 0) { | ||
| return Nan; |
fix infinite loop error and updated type in NaN.
Fixed infinite loop error and fixed NaN typo.
|
Had some wifi issues when committing the pull request so apologies if there is a duplicate. |
no problem - commits are free so do it all you want :) |
learyjk
reviewed
Nov 9, 2023
src/01-2-basics.js
Outdated
| if (typeof word !== "string" || word === "null") { | ||
| return ""; | ||
| } | ||
| return word.charAt(0).toUpperCase() + word.slice(1).toLocaleLowerCase(); |
There was a problem hiding this comment.
this return statement should be outside the second if statement - then I think you will pass all the tests 💯
toLowerCase had auto filled to toLocaleLowerCase. return bandName added. All tests passed 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passed 🤙