Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tooltip design #1449

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Improve tooltip design #1449

merged 5 commits into from
Mar 12, 2025

Conversation

ericboucher
Copy link
Collaborator

@ericboucher ericboucher commented Mar 12, 2025 •
edited
Loading

Description

Improve tooltip behavior by:

  • using colors to display the status of each hour
  • always display storm name even when there is only one
  • add tooltip "enter" and "leave" delays to make it a bit easier to move to the tooltip before it disappears
Screenshot 2025-03-12 at 3 38 38 PM Screenshot 2025-03-12 at 3 39 46 PM

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

@ericboucher ericboucher requested a review from wadhwamatic March 12, 2025 14:42
@ericboucher ericboucher changed the title Update index.tsx Improve tooltip design Mar 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8ed6322):

https://staging-prism-frontend--prism-1449-slhbkurd.web.app

(expires Fri, 11 Apr 2025 18:22:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4de97634797dc19a4f4938b370446c2b3ddc1c37

wadhwamatic
wadhwamatic approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@wadhwamatic wadhwamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great. big improvement thanks @ericboucher !

@ericboucher ericboucher merged commit ba769c3 into update-readiness-coloring Mar 12, 2025
8 checks passed
@ericboucher ericboucher deleted the tooltip-improvement branch March 12, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadhwamatic wadhwamatic wadhwamatic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericboucher @wadhwamatic