Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the Contributing section #310

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Updates to the Contributing section #310

merged 3 commits into from
Feb 4, 2025

Conversation

pardel
Copy link
Contributor

@pardel pardel commented Feb 4, 2025

  • no need to clarify we're using python3
  • using source to activate the virtual environment in Mac/Linux (as per https://docs.python.org/3/library/venv.html#how-venvs-work)
  • Since testutils is a local module, we need to ensure it is discoverable when running the tests - we achieve this by setting the PYTHONPATH environment variable

- no need to clarify we're using python3
- using `source` to activate the virtual environment in Mac/Linux (as per https://docs.python.org/3/library/venv.html#how-venvs-work)
- Since testutils is a local module, we need to ensure it is discoverable when running the tests - we achieve this by setting the PYTHONPATH environment variable
@pardel pardel requested a review from maxkahan February 4, 2025 15:01
@pardel pardel requested a review from maxkahan February 4, 2025 15:57
@maxkahan maxkahan merged commit 85a7fc0 into main Feb 4, 2025
10 checks passed
@maxkahan maxkahan deleted the updates-contribution branch February 4, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants