-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field settings per user #21
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after deleting node_modules and install dependenceis
npm run dev
compiles but with errors
Type-checking in progress...
ERROR in ./src/app/features/explore/utils/links.ts:129:28
TS2339: Property 'transformations' does not exist on type 'InternalDataLink<any>'.
127 | } else {
128 | let internalLinkSpecificVars: ScopedVars = {};
> 129 | if (link.internal?.transformations) {
| ^^^^^^^^^^^^^^^
130 | link.internal?.transformations.forEach((transformation) => {
131 | let fieldValue;
132 | if (transformation.field) {
ERROR in ./src/app/features/explore/utils/links.ts:130:26
TS2339: Property 'transformations' does not exist on type 'InternalDataLink<any>'.
128 | let internalLinkSpecificVars: ScopedVars = {};
129 | if (link.internal?.transformations) {
> 130 | link.internal?.transformations.forEach((transformation) => {
| ^^^^^^^^^^^^^^^
131 | let fieldValue;
132 | if (transformation.field) {
133 | const transformField = dataFrame?.fields.find((field) => field.name === transformation.field);
ERROR in ./src/app/features/explore/utils/links.ts:130:51
TS7006: Parameter 'transformation' implicitly has an 'any' type.
128 | let internalLinkSpecificVars: ScopedVars = {};
129 | if (link.internal?.transformations) {
> 130 | link.internal?.transformations.forEach((transformation) => {
| ^^^^^^^^^^^^^^
131 | let fieldValue;
132 | if (transformation.field) {
133 | const transformField = dataFrame?.fields.find((field) => field.name === transformation.field);
Found 3 errors in 2037 ms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep frame settings shown after change. User should have to select all options and close it after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@mikhail-vl ready for review
Issue:
Would it possible to update the Time Series (Volkov Labs) plugin to enable the user to select which variables to see in the Time Series and save by profile as shown below:
Settings in popup: