Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field settings per user #21

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

vitPinchuk
Copy link
Contributor

Issue:
Would it possible to update the Time Series (Volkov Labs) plugin to enable the user to select which variables to see in the Time Series and save by profile as shown below:
image

Settings in popup:
image

@vitPinchuk vitPinchuk self-assigned this Jan 14, 2025
@vitPinchuk vitPinchuk marked this pull request as draft January 14, 2025 13:53
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 15, 2025
@vitPinchuk vitPinchuk marked this pull request as ready for review January 15, 2025 04:57
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after deleting node_modules and install dependenceis
npm run dev compiles but with errors

Type-checking in progress...
ERROR in ./src/app/features/explore/utils/links.ts:129:28
TS2339: Property 'transformations' does not exist on type 'InternalDataLink<any>'.
    127 |       } else {
    128 |         let internalLinkSpecificVars: ScopedVars = {};
  > 129 |         if (link.internal?.transformations) {
        |                            ^^^^^^^^^^^^^^^
    130 |           link.internal?.transformations.forEach((transformation) => {
    131 |             let fieldValue;
    132 |             if (transformation.field) {

ERROR in ./src/app/features/explore/utils/links.ts:130:26
TS2339: Property 'transformations' does not exist on type 'InternalDataLink<any>'.
    128 |         let internalLinkSpecificVars: ScopedVars = {};
    129 |         if (link.internal?.transformations) {
  > 130 |           link.internal?.transformations.forEach((transformation) => {
        |                          ^^^^^^^^^^^^^^^
    131 |             let fieldValue;
    132 |             if (transformation.field) {
    133 |               const transformField = dataFrame?.fields.find((field) => field.name === transformation.field);

ERROR in ./src/app/features/explore/utils/links.ts:130:51
TS7006: Parameter 'transformation' implicitly has an 'any' type.
    128 |         let internalLinkSpecificVars: ScopedVars = {};
    129 |         if (link.internal?.transformations) {
  > 130 |           link.internal?.transformations.forEach((transformation) => {
        |                                                   ^^^^^^^^^^^^^^
    131 |             let fieldValue;
    132 |             if (transformation.field) {
    133 |               const transformField = dataFrame?.fields.find((field) => field.name === transformation.field);

Found 3 errors in 2037 ms.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep frame settings shown after change. User should have to select all options and close it after

@vitPinchuk vitPinchuk requested a review from asimonok January 17, 2025 14:11
src/plugins/frameSettings/FrameSettingsEditor.tsx Outdated Show resolved Hide resolved
src/TimeSeriesPanel.tsx Outdated Show resolved Hide resolved
@vitPinchuk vitPinchuk requested a review from asimonok January 17, 2025 14:25
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants