feat: logger #200
Open
feat: logger #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman533
added
enhancement
BeierKevin
previously approved these changes
Jun 7, 2023
Claiyc
requested changes
Jun 7, 2023
| /** | ||
| * Electron log levels enum declaration | ||
| */ | ||
| export enum ElectronLogLevel { |
There was a problem hiding this comment.
just updating the values for these enums to numbers (as in .env) may be a good solution
There was a problem hiding this comment.
However you need to make sure that eg. loglevel INFO also includes everything WARN & ERROR (this only makes sense)
There was a problem hiding this comment.
Maybe we still need to discuss what we really want out of this
Claiyc
reviewed
Jun 7, 2023
There was a problem hiding this comment.
the logfile should be created in the root directory of the installation location (and not somewhere in appdata). Maybe in some subfolder logs/
There was a problem hiding this comment.
This needs to be tested for an actually installed application as well as in dev environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
Created a composable for a logger with electron-log and tslog
Definition Of Done (DoD)
This PR can be squashed / merged if
fixes: #167
Add additional conditions here if necessary for this PR