Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-3019]: align interface with IL comptroller #548

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

coreyar
Copy link
Collaborator

@coreyar coreyar commented Jan 20, 2025

Description

  • added isMarketListed
  • added getBorrowingPower
  • supportMarket alias of _supportMarket
  • getAccountLiquidity alias of _getAccountLiquidity
  • setPriceOracle alias of _setPriceOracle
  • setCloseFactor alias of _setCloseFactor
  • setCollateralFactor alias of _setCollateralFactor
  • setLiquidationIncentive alias of _setLiquidationIncentive
  • setMarketBorrowCaps alias of _setMarketBorrowCaps
  • setMarketSupplyCaps alias of _setMarketSupplyCaps
  • setPrimeToken alias of _setPrimeToken
  • setForcedLiquidation alias of _setForcedLiquidationForUser

@coreyar coreyar requested review from chechu and kkirka January 20, 2025 15:04
@coreyar coreyar force-pushed the udpate-unitroller-to-align-more-with-il-comptroller branch 2 times, most recently from f990bab to 3b046d2 Compare January 20, 2025 15:56
@coreyar coreyar force-pushed the udpate-unitroller-to-align-more-with-il-comptroller branch from 3b046d2 to 6b6d90f Compare January 20, 2025 16:58
@chechu chechu changed the title feat: align interface with IL comptroller [VEN-3019]: align interface with IL comptroller Jan 27, 2025
@coreyar coreyar force-pushed the udpate-unitroller-to-align-more-with-il-comptroller branch from 028b31f to 5fb1a98 Compare February 6, 2025 20:42
@coreyar coreyar force-pushed the udpate-unitroller-to-align-more-with-il-comptroller branch from 5fb1a98 to bc49c80 Compare February 6, 2025 20:51
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100%
contracts.Admin 88% 41%
contracts.Comptroller 100% 90%
contracts.Comptroller.Diamond 95% 59%
contracts.Comptroller.Diamond.facets 76% 64%
contracts.Comptroller.Diamond.interfaces 100% 100%
contracts.DelegateBorrowers 100% 89%
contracts.Governance 68% 45%
contracts.InterestRateModels 74% 59%
contracts.Lens 45% 37%
contracts.Liquidator 83% 60%
contracts.Oracle 100% 100%
contracts.PegStability 88% 84%
contracts.Swap 91% 58%
contracts.Swap.interfaces 100% 100%
contracts.Swap.lib 81% 55%
contracts.Tokens 100% 100%
contracts.Tokens.Prime 96% 72%
contracts.Tokens.Prime.Interfaces 100% 100%
contracts.Tokens.Prime.libs 90% 76%
contracts.Tokens.VAI 81% 53%
contracts.Tokens.VRT 20% 9%
contracts.Tokens.VTokens 64% 47%
contracts.Tokens.VTokens.legacy 0% 0%
contracts.Tokens.XVS 19% 8%
contracts.Utils 50% 30%
contracts.VAIVault 50% 45%
contracts.VRTVault 49% 36%
contracts.XVSVault 64% 50%
contracts.lib 89% 71%
Summary 63% (3373 / 5393) 45% (1244 / 2738)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant