Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2375]: Feat RedeemBehalf and RedeemUnderlyingBehalf #442

Merged
merged 29 commits into from
Mar 19, 2024
Merged

Conversation

Debugger022
Copy link
Contributor

Description

Resolves #VEN-2375

This PR adds the following new functionalities in the VToken contract:

  1. RedeemBehalf
  2. RedeemUnderlyingBehalf

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@chechu chechu added the audit This content is being audited label Feb 9, 2024
@chechu chechu added this to the 031 milestone Feb 9, 2024
Copy link
Collaborator

@kkirka kkirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the param name, thank you! <3

Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100%
contracts.Admin 88% 41%
contracts.Comptroller 100% 90%
contracts.Comptroller.Diamond 95% 59%
contracts.Comptroller.Diamond.facets 75% 65%
contracts.Comptroller.Diamond.interfaces 100% 100%
contracts.DelegateBorrowers 100% 89%
contracts.Governance 33% 20%
contracts.InterestRateModels 47% 67%
contracts.Lens 43% 35%
contracts.Liquidator 83% 60%
contracts.Oracle 100% 100%
contracts.PegStability 88% 84%
contracts.Swap 88% 58%
contracts.Swap.interfaces 100% 100%
contracts.Swap.lib 81% 55%
contracts.Tokens 100% 100%
contracts.Tokens.Prime 96% 72%
contracts.Tokens.Prime.Interfaces 100% 100%
contracts.Tokens.Prime.libs 90% 76%
contracts.Tokens.VAI 71% 46%
contracts.Tokens.VRT 20% 9%
contracts.Tokens.VTokens 68% 49%
contracts.Tokens.XVS 19% 8%
contracts.Utils 50% 30%
contracts.VAIVault 50% 45%
contracts.VRTVault 49% 36%
contracts.XVSVault 64% 50%
contracts.lib 75% 25%
Summary 69% (3163 / 4603) 49% (1179 / 2408)

@Debugger022 Debugger022 merged commit 16493f6 into develop Mar 19, 2024
4 checks passed
@chechu chechu mentioned this pull request Mar 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit This content is being audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants