Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2322] Unlist Market #429

Merged
merged 42 commits into from
Jun 6, 2024
Merged

[VEN-2322] Unlist Market #429

merged 42 commits into from
Jun 6, 2024

Conversation

web3rover
Copy link
Collaborator

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover self-assigned this Jan 19, 2024
@web3rover web3rover marked this pull request as ready for review January 22, 2024 10:47
_actionPaused[market][uint256(Action.ENTER_MARKET)] = true;
_actionPaused[market][uint256(Action.LIQUIDATE)] = true;

borrowCaps[market] = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borrowCaps = 0 means unlimited borrowing, see here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we will be fixing it as part of another ticket and upgrade the comptroller.

@chechu chechu added this to the 032 milestone Feb 23, 2024
@Debugger022 Debugger022 self-requested a review March 21, 2024 10:27
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100%
contracts.Admin 88% 41%
contracts.Comptroller 100% 90%
contracts.Comptroller.Diamond 95% 59%
contracts.Comptroller.Diamond.facets 76% 64%
contracts.Comptroller.Diamond.interfaces 100% 100%
contracts.DelegateBorrowers 100% 89%
contracts.Governance 33% 20%
contracts.InterestRateModels 47% 67%
contracts.Lens 45% 37%
contracts.Liquidator 83% 60%
contracts.Oracle 100% 100%
contracts.PegStability 88% 84%
contracts.Swap 88% 58%
contracts.Swap.interfaces 100% 100%
contracts.Swap.lib 81% 53%
contracts.Tokens 100% 100%
contracts.Tokens.Prime 96% 72%
contracts.Tokens.Prime.Interfaces 100% 100%
contracts.Tokens.Prime.libs 90% 76%
contracts.Tokens.VAI 71% 46%
contracts.Tokens.VRT 20% 9%
contracts.Tokens.VTokens 64% 47%
contracts.Tokens.XVS 19% 8%
contracts.Utils 50% 30%
contracts.VAIVault 50% 45%
contracts.VRTVault 49% 36%
contracts.XVSVault 64% 50%
contracts.lib 75% 25%
Summary 69% (3204 / 4671) 49% (1200 / 2456)

@web3rover web3rover changed the base branch from develop to feat/borrow-cap-fix May 22, 2024 12:47
@web3rover web3rover requested a review from chechu May 24, 2024 07:17
@chechu chechu removed the audit This content is being audited label May 24, 2024
@chechu
Copy link
Member

chechu commented Jun 4, 2024

MarketFacet is only needed on bsctestnet and bscmainnet. We don't have a Core Comptroller with a Diamond on any other network, so those deployment files should be removed

@web3rover
Copy link
Collaborator Author

MarketFacet is only needed on bsctestnet and bscmainnet. We don't have a Core Comptroller with a Diamond on any other network, so those deployment files should be removed

Removed opbnbtestnet and sepolia deployments

@web3rover web3rover merged commit 325aebc into feat/borrow-cap-fix Jun 6, 2024
@chechu chechu mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants