[VEN -2250] Reduce reserves with available cash #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
VEN-2250-reduce-reserves-with-available-cash
branch
from
95997e4 to
0a245be
Compare
chechu
reviewed
Dec 18, 2023
coreyar
force-pushed
the
VEN-2250-reduce-reserves-with-available-cash
branch
2 times, most recently
from
3db8306 to
d57c5dc
Compare
coreyar
force-pushed
the
VEN-2250-reduce-reserves-with-available-cash
branch
2 times, most recently
from
7dc8fc1 to
4b4363a
Compare
coreyar
force-pushed
the
VEN-2250-reduce-reserves-with-available-cash
branch
4 times, most recently
from
6bf1da4 to
1526bdf
Compare
chechu
added
don't merge
chechu
approved these changes
Dec 19, 2023
If there is not enough cash to reduce reserves when accruing interest the call will break which prevents calculating fresh balances. Rather then error if reserves can't be reduced fully, we can reduce them with available cash
coreyar
force-pushed
the
VEN-2250-reduce-reserves-with-available-cash
branch
from
1526bdf to
53e37eb
Compare
…d setProtocolShareReserve()
|
web3rover
approved these changes
Jan 17, 2024
chechu
approved these changes
Feb 16, 2024
GitGuru7
approved these changes
Feb 19, 2024
Debugger022
approved these changes
Feb 19, 2024
0xlucian
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When accruing interest we reduce reserves. If there isn't enough available cash the accrual would error which causes problems like preventing fresh account balances from being calculated.
This change reduces the reserves with available cash if it is less then the accrued revenue.