feat: support whitelisted proposers #116
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
commented
Jan 23, 2025
coreyar
force-pushed
the
white-list-proposers
branch
5 times, most recently
from
87a1dda to
753a5a5
Compare
coreyar
force-pushed
the
white-list-proposers
branch
4 times, most recently
from
9754981 to
d674786
Compare
This reverts commit 5fc0e65.
GitGuru7
reviewed
Feb 25, 2025
|
|
||
| uint latestProposalId = latestProposalIds[msg.sender]; | ||
| if ( | ||
| whitelistedProposers[msg.sender] != address(0) && |
There was a problem hiding this comment.
Do we need to check this condition again, as we are already ensuring it in previous condition?
GitGuru7
reviewed
Feb 25, 2025
| _; | ||
| } | ||
|
|
||
| modifier onlyGuardianOrAdmin() { |
There was a problem hiding this comment.
Should we remove it as we are using ACM for authorisation?
GitGuru7
reviewed
Feb 25, 2025
| * @param proposer The address of the proposer to whitelist | ||
| */ | ||
| function whitelistProposer(address proposer, ProposalType proposalType) external { | ||
| _checkAccessAllowed("whitelistProposer(address,ProposalType)"); |
There was a problem hiding this comment.
Suggested change
| _checkAccessAllowed("whitelistProposer(address,ProposalType)"); | |
| _checkAccessAllowed("whitelistProposer(address,ProposalType)"); | |
| ensureNonzeroAddress(proposer) |
GitGuru7
reviewed
Feb 25, 2025
| @@ -280,35 +364,61 @@ contract GovernorBravoDelegate is GovernorBravoDelegateStorageV2, GovernorBravoE | |||
| emit ProposalQueued(proposalId, eta); | |||
| } | |||
|
|
|||
| /** | |||
| * @notice Whitelists a proposer | |||
| * @param proposer The address of the proposer to whitelist | |||
There was a problem hiding this comment.
natspec is missing for event and access
GitGuru7
reviewed
Feb 25, 2025
| require(c >= a, "addition overflow"); | ||
| return c; | ||
| } | ||
|
|
||
| function sub256(uint256 a, uint256 b) internal pure returns (uint) { | ||
| function sub256(uint256 a, uint256 b) internal pure returns (uint256) { |
There was a problem hiding this comment.
We don;t these functionalities to check overflows in 0.8.25 version of solidity.
coreyar
force-pushed
the
white-list-proposers
branch
from
d674786 to
d8b8274
Compare
GitGuru7
reviewed
Feb 28, 2025
| @@ -70,30 +73,30 @@ import "./GovernorBravoInterfaces.sol"; | |||
| * The delegation of votes happens through the `XVSVault` contract by calling the `delegate` or `delegateBySig` functions. These same functions can revert | |||
| * vote delegation by calling the same function with a value of `0`. | |||
| */ | |||
| contract GovernorBravoDelegate is GovernorBravoDelegateStorageV2, GovernorBravoEvents { | |||
| contract GovernorBravoDelegate is GovernorBravoDelegateStorageV2, GovernorBravoEvents, AccessControlledV8 { | |||
There was a problem hiding this comment.
I suggest inheriting from GovernorBravoDelegateStorageV2 and creating an additional storage contract. This will allow us to add new storage elements as needed, particularly for syncing votes. Additionally, we should consider moving the custom errors into GovernorBravoEvents or creating a separate file for them to help clean up the code.
GitGuru7
reviewed
Feb 28, 2025
| @@ -102,67 +105,145 @@ contract GovernorBravoDelegate is GovernorBravoDelegateStorageV2, GovernorBravoE | |||
| /// @notice The EIP-712 typehash for the ballot struct used by the contract | |||
| bytes32 public constant BALLOT_TYPEHASH = keccak256("Ballot(uint256 proposalId,uint8 support)"); | |||
|
|
|||
| /// @notice Mapping to store whitelisted proposers and the timelock they are authorized to use | |||
| mapping(address => address) public whitelistedProposers; | |||
There was a problem hiding this comment.
What is one proposer is authorized for multiple timelocks? Correct me if I am wrong.
Suggested change
| mapping(address => address) public whitelistedProposers; | |
| mapping(address => address[]) public whitelistedProposers; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to support whitelisted proposers that can be set and removed with a timelock. The idea is to allow programmatically creating proposals.