feat(new features): adds features, read pr for details #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadan4
commented
Aug 20, 2024
src/extension.ts
Outdated
Comment on lines
20
to
27
| workspace.registerTextDocumentContentProvider("vencord-companion", { | ||
| async provideTextDocumentContent(uri) { | ||
| console.log(uri) | ||
| //FIXME: full uri shows up in title bar | ||
| const newLocal = Buffer.from(uri.path.substring(1, uri.path.lastIndexOf(".")), "base64url"); | ||
| return newLocal.toString() | ||
| }, | ||
| }), |
There was a problem hiding this comment.
this seems like a really bad way to create a diff between two strings, but I tried for like a few hours and I couldn't figure out any other way
update esbuild update build system add webview to normal build system update scripts compile => build
|
I think all the features are done, but this is still nowhere near ready
review is appreciated from whoever offers it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS NEEDS TO BE REVIEWED
needs to be merged with the matching pr in the vencord repo
if you have any ideas for features, ping me on discord
current planned features