Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yda 5981 reporting server #495

Open
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

leonidastri
Copy link
Contributor

No description provided.

@lwesterhof lwesterhof self-requested a review November 12, 2024 07:42
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, review the feedback from GitHub Actions concerning newlines and the fully qualified class names (FQCN) for built-in module actions.

environments/development/allinone/host_vars/combined Outdated Show resolved Hide resolved
gather-group-statistics.py Outdated Show resolved Hide resolved
roles/yoda_report/defaults/main.yml Outdated Show resolved Hide resolved
playbook.yml Outdated Show resolved Hide resolved
@@ -2,6 +2,7 @@
# copyright Utrecht University

enable_mailpit: false
enable_yoda_report: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable not needed in this role.

environments/development/full/group_vars/full.yml Outdated Show resolved Hide resolved

Variable | Description
--------------------|-----------------------------------------------------------
enable_yoda_report: | Enable installation of yoda report for financial reporting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary colon after the variable name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants