-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Entra ID SAML SSO docs #8151
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @daveleek:
Right now, it seems we do not support namespaces at all in our claims for firstName and lastName. We also show two different sets of claims names, one uses firstName & lastName which without namespaces would be correct. the other one under group sync shows givenname and surname with namespaces which doesn't appear to work with our without namespaces.
I can't user.firstName
or user.lastName
attributes in the Entra admin UI anymore, I think they removed them. In the new screenshot, I'm only showing user.mail
as an attribute. Not sure if we want to explicitly mention, that we don't support any others? 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, that's interesting! Going to have to check the other test setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah gone there too, just a dropdown now with valid values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we use firstName and lastName claims (transformed in Entra ID from givenname and surname) to set the full name of the user in Unleash
Ok checked and we do. Looks like we need 3 claims to set up a user with an email + a name; Unique User Identifier, firstName, and lastName. And groups for group sync. I guess that makes the name parameter in my screenshot above redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
So should we specifically state in the instructions to add user.surname
and user.givenname
claims without namespaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we should at least explain that it's how user names get populated in Unleash, it'll work without them but that might look/feel weird as the users get listed with just the email address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, love the improved language/details here. Would be good to add in a small explanation around firstName/lastName like we discussed, but apart from that LGTM! :)
About the changes
Updates the
AzureEntra ID SAML SSO docs to reflect the latest product name changes from Microsoft, update (and remove) some screenshots, and ensure that claims + namespaces are correctly shown.Docs deeplink-> How to Add SSO with SAML 2.0 and Microsoft Entra ID