Make Stuff Bigger #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hicks927
reviewed
May 13, 2021
Comment on lines
73
to
80
| if (second < 45) { | ||
| Timelord.setCurrentShowName("News intro in " + (45 - second) + "...", 'news'); | ||
| Timelord.setNewsCountdown("NEWS INTRO", (45 - second)); | ||
| } else if (second <= 52) { | ||
| Timelord.setCurrentShowName((52 - second) + " until voice over...", 'news'); | ||
| Timelord.setNewsCountdown("VOICE OVER", (52-second)); | ||
| } else { | ||
| Timelord.setNewsCountdown(false, 0); | ||
| Timelord.setCurrentShowName(Timelord._config.short_name + ' News', 'news'); | ||
| } |
There was a problem hiding this comment.
Could we have an exception where it displays in current position if breaking news here?
|
A) Yes, you're going blind. D) What happens if the breaking news tab is active (say we're using it to display a timer during CIN) when we still want news coundown? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making stuff bigger. I can't be the first presenter to think its all too small when its on the other side of the room? Or am I just going blind?