Poetry setup in readme #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashhhleyyy
requested changes
Aug 27, 2024
| @@ -47,7 +48,9 @@ On MacOS: | |||
|
|
|||
| ### Running | |||
|
|
|||
| To just run the server standalone without installing, run `python ./launch.py`. | |||
| To run the server standalone without installing BAPSicle, you'll need to install the dependencies. | |||
| Run `poetry install` in the root directory to install them. | |||
There was a problem hiding this comment.
Suggested change
| Run `poetry install` in the root directory to install them. | |
| Run `poetry install` in the root directory to install them. | |
| BAPSicle also requires a built version of the [presenter UI](https://github.com/UniversityRadioYork/WebStudio) in order to use; run `npm run presenter-make` to build it (the output will be in `presenter-ui`/). |
| @@ -39,6 +39,7 @@ Starting and stopping the server, as well as UI links, are available in the Syst | |||
| On all platforms: | |||
|
|
|||
| - Python 3.8 - 3.11 Tested | |||
| - [Poetry](https://python-poetry.org/) | |||
There was a problem hiding this comment.
Suggested change
| - [Poetry](https://python-poetry.org/) | |
| - [Poetry](https://python-poetry.org/) | |
| - NodeJS and Yarn 1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the migration was made to poetry the setup instructions in the readme were not update to reflect that change.
I've tried my best to do that having never used poetry before lmao if u can make sure these are what you expected before merge BCS I can't fully test this I have an (I assume) unrelated bug.
kthxxx