Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAT-376] Sync Fork to get ORTB 2.6 changes #35

Merged
merged 52 commits into from
Mar 26, 2024
Merged

[PAT-376] Sync Fork to get ORTB 2.6 changes #35

merged 52 commits into from
Mar 26, 2024

Conversation

rourkewhite
Copy link
Collaborator

@rourkewhite rourkewhite commented Mar 25, 2024 •
edited
Loading

sync fork with upstream repo.
pulls in additive changes only to not break existing references
https://jira.unity3d.com/browse/PAT-376

Skipped changes:

  • variable renaming
  • type changes
    • content.context can be unmarshaled from an int or string upstream; keeping int only
    • a bunch of fields were made into custom enum types upstream; keeping basic types for pre-existing fields
    • upstream all ext fields were made into the json.RawMessage type. keeping the openrtb.Extension type declaration, but now as a json.RawMessage alias. this shouldn't break current type references

venediktov and others added 30 commits November 1, 2017 20:40
@venediktov
fix StringOrNumber for empty strings
6880b63
add test for empty StringOrNumber encoder/decoder
6442b40
@dim
Merge pull request bsm#46 from vanilla-rtb/master
7b145eb 
fix StringOrNumber for empty strings
@sgodart
Content, fix typo in Album property json tag
8bc7f15
@dim
Merge pull request bsm#50 from ividence/master
8d41110 
Content: fix typo in Album property json tag
@AaronReboot
Change type on Content.Context from int to NumberOrString
cb99031
@AaronReboot
Add test for quoted context field in Content object
fd328b9
@dim
Merge pull request bsm#54 from MadHive/master
de6e90d 
Change type on Content.Context from int to NumberOrString
@dim
Bump CI config
87b0a29
@dim
Use go mod
678b6f1
@dim
Fix build
9c04274
@saifat29
Add omitempty to Native Ad Response Link struct
0438498 
`clicktrackers` field is optional according to the IAB spec and should be omitted if empty.
@dim
Merge pull request bsm#58 from saifat29/patch-1
643b4f1 
Add omitempty to Native Ad Response Link struct
@mxmCherry
switch back custom Extension to json.RawMessage
9e640fb 
It's marshaling non-pointers fine as of Go 1.8: https://golang.org/doc/go1.8#encoding_json
@mxmCherry
readme: add a Requirements section, mentioning Go 1.8+
d4bd648
@dim
Merge pull request bsm#63 from mxmCherry/feature/use-json-rawmessage
88dbbc5 
switch back custom Extension to json.RawMessage
@dim
Bump deps, tidy
b972a5c
add vcm attr to banner
3b1a908
fix banner test for vcm
75ebdae
@dim
Merge pull request bsm#67 from EastResident/feature/vcm
f0c31f9 
Add "vcm" attribute to banner object
@dim
New major release
62ce92d
@dim
Merge pull request bsm#68 from bsm/feature/v3
da7bfdf 
Ready for v3
remove min and max duration validation
ebea466
@dim
Merge pull request bsm#69 from EastResident/feature/video_duration_op…
665256b 
…tional

Not validate "video.minduration" and "maxduration"
@Sky-Zeng
fix ContentCategory.
dfdddca
@dim
Merge pull request bsm#72 from Sky-Zeng/skz_cat
43045f3 
fix ContentCategory.
fix a typo in 3D Graphics Content Category
c72f27d
@dim
Merge pull request bsm#74 from ollevche/fix-typo
ebc36e8 
fix a typo in 3D Graphics Content Category
@dim
Fix formatting
a958dfa
@ollevche
fix a typo in 7-12 Education Content Category
385531a
dim and others added 22 commits April 14, 2020 11:59
@dim
Merge pull request bsm#76 from ollevche/fix-typo
1edcd29 
fix a typo in 7-12 Education Content Category
Format ratio added
7b78264
@dim
Merge pull request bsm#91 from jrobin42/master
6f64bb3 
Format ratio added
@stokito
Add device.sua
ac42b90 
Structured user agent information. Was added to OpenRTB v2.6

https://github.com/google/ads-privacy/blob/master/experiments/structured-ua/openrtb.md
@dim
Merge pull request bsm#92 from stokito/add_sua
12c76e8 
Add device.sua
@dim
Modernise, remove deps (bsm#93)
b106b7e
@Katsukiniwa
Fix sua browsers type (bsm#96)
56ba587
@MasatoraAtarashi
Fix sua source type (bsm#98)
24701da
@shivakumarss
- Introduction of ooh device type | (bsm#100)
4cbc130
@pd-pranay
Add ortb 2.6 features to video object (bsm#101)
7dda58d
@pd-pranay
Add open rtb 2.6 features in Bid Response (seatbid.bid) (bsm#102)
74f390a
@pd-pranay
Request to add new Video Placement support. (bsm#104)
5129f80
@saifat29
Remove omitempty from w and h of Video object (bsm#105) (bsm#106)
2214def
@pd-pranay
Add ortb 2.6 features to content object (bsm#108)
071ec74
@codenaugh
full support for langb fields (bsm#109)
5563255
@teixeiratho
support oRTB 2.6 qty field in impressions object (bsm#111)
5547ba6
@codenaugh
Add OpenRTB 2.6 Regulation fields (bsm#115)
e622479
@rourkewhite
sync fork. pulls in additive changes only to not break existing refer…
53155b9 
…ences
@rourkewhite
fix go mod
8288bbc
@rourkewhite
fix seatbid test
54bcae9
@rourkewhite
fix quantity test
0d1b208
@rourkewhite
fix extension marshaling and tests
f9fae6e
@rourkewhite rourkewhite changed the title Sync Fork to get ORTB 2.6 changes [PAT-376] Sync Fork to get ORTB 2.6 changes Mar 26, 2024
@rourkewhite rourkewhite marked this pull request as ready for review March 26, 2024 01:01
zephanjohnson
zephanjohnson approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@zephanjohnson zephanjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@rourkewhite rourkewhite merged commit 6c1a9c3 into master Mar 26, 2024
3 checks passed
@rourkewhite rourkewhite deleted the syncFork branch March 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zephanjohnson zephanjohnson zephanjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.