Refactor ELO rating update logic in GhostTrainer #6138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
update_elo_ratings
in theGhostTrainer
class_process_trajectory
method to callupdate_elo_ratings
This is a very simple change for readability that is all.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
N/A
Types of change(s)
Checklist
Other comments
This refactor improves the modularity of the ELO rating update logic, making it easier to maintain and potentially reuse in other parts of the codebase if needed. The functionality remains unchanged, so existing behavior should not be affected. However, it's recommended to run the existing test suite to ensure no unintended side effects.