Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ELO rating update logic in GhostTrainer #6138

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

OMS1996
Copy link

@OMS1996 OMS1996 commented Aug 28, 2024

  • Extract ELO rating update logic from _process_trajectory into a new method update_elo_ratings
  • Improves code organization and reusability
  • No functional changes to the ELO update algorithm

Proposed change(s)

  • Created a new method update_elo_ratings in the GhostTrainer class
  • Modified the _process_trajectory method to call update_elo_ratings
  • The new method encapsulates the logic for updating ELO ratings based on trajectory outcomes

This is a very simple change for readability that is all.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

N/A

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

This refactor improves the modularity of the ELO rating update logic, making it easier to maintain and potentially reuse in other parts of the codebase if needed. The functionality remains unchanged, so existing behavior should not be affected. However, it's recommended to run the existing test suite to ensure no unintended side effects.

- Extract ELO rating update logic from _process_trajectory into a new method update_elo_ratings
- Improves code organization and reusability
- No functional changes to the ELO update algorithm
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

@OMS1996
Copy link
Author

OMS1996 commented Aug 28, 2024

@miguelalonsojr @erikfrey @furkan-celik I was wondering if you could review this, Just want to get my feet wet in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants