Remove unused TouchedTarget() methods from examples #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crawler, Walker, and Worm all have TouchedTarget methods to add +1 reward that are, as near as I can tell, completely unused. These are not mentioned anywhere in documentation and are potentially very confusing to someone examining the example code. Remove this methods to make the code cleaner and easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Crawler, Walker, and Worm all have TouchedTarget methods to add +1 reward
that are, as near as I can tell, completely unused. These are not mentioned
anywhere in documentation and are potentially very confusing to someone
examining the example code. Remove this methods to make the code cleaner
and easier to read.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Replacing #5768 so I am not merging from my main branch.
Types of change(s)
Checklist
Other comments