-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Make displayIndex usable for PenState #1976
base: develop
Are you sure you want to change the base?
FIX: Make displayIndex usable for PenState #1976
Conversation
Hi @brice-gros and thanks for opening this draft PR. Are you expecting to do more work on it or have you accidentally not marked it ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, PR only misses an entry in CHANGELOG.md and needs to be updated based on latest develop
Adding QA to PR. Also would recommend testing Pen on other platforms that targeted platform and for various Unity generations. |
I don't have any pen devices, added @stefanunity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-I don't have an android with a pen, even less the exact device Brice has
-I tested some pen and touch/pointer input on Windows touch screen and wacom + pen
-nothing bad happened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Description
Make displayIndex usable for PenState.
Changes made
Use the displayIndex from PenState to get the target display
Testing
Tested on Android 14
Risk
PenState not working on non-Android platform
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: