Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make displayIndex usable for PenState #1976

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

brice-gros
Copy link

@brice-gros brice-gros commented Aug 1, 2024

Description

Make displayIndex usable for PenState.

Changes made

Use the displayIndex from PenState to get the target display

Testing

Tested on Android 14

Risk

PenState not working on non-Android platform

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Aug 1, 2024

CLA assistant check
All committers have signed the CLA.

@ekcoh
Copy link
Collaborator

ekcoh commented Sep 13, 2024

Hi @brice-gros and thanks for opening this draft PR. Are you expecting to do more work on it or have you accidentally not marked it ready for review?

@brice-gros brice-gros changed the title Make displayIndex usable for PenState FIX: Make displayIndex usable for PenState Sep 16, 2024
@brice-gros brice-gros marked this pull request as ready for review September 16, 2024 09:22
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, PR only misses an entry in CHANGELOG.md and needs to be updated based on latest develop

@ekcoh
Copy link
Collaborator

ekcoh commented Sep 24, 2024

Adding QA to PR. Also would recommend testing Pen on other platforms that targeted platform and for various Unity generations.

@Pauliusd01
Copy link
Collaborator

I don't have any pen devices, added @stefanunity

@Pauliusd01 Pauliusd01 removed their request for review September 25, 2024 07:41
Copy link
Collaborator

@stefanunity stefanunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-I don't have an android with a pen, even less the exact device Brice has
-I tested some pen and touch/pointer input on Windows touch screen and wacom + pen
-nothing bad happened

@brice-gros brice-gros requested a review from ekcoh October 14, 2024 11:07
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants