Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit get #351

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Add limit get #351

merged 6 commits into from
Feb 6, 2024

Conversation

robert-seitz-uniswap
Copy link
Collaborator

@robert-seitz-uniswap robert-seitz-uniswap commented Feb 2, 2024

adds GET /prod/limit/orders

curl --location '/prod/limit/orders?orderStatus=open'

response:

{
    "orders": [
        {
            "outputs": [
                {
                    "recipient": "0x5d5577a33abbbae5e7235d2d080caff47e94b7d0",
                    "startAmount": "37563544125610598",
                    "endAmount": "23722713488525370",
                    "token": "0x0000000000000000000000000000000000000000"
                }
            ],
            "encodedOrder": "0x000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000001200000000000000000000000000000000000000000000000000000000065bbc3650000000000000000000000000000000000000000000000000000000065bbc41900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a0b86991c6218b36c1d19d4a2e9eb0ce3606eb480000000000000000000000000000000000000000000000000000000005f5e1000000000000000000000000000000000000000000000000000000000005f5e10000000000000000000000000000000000000000000000000000000000000002000000000000000000000000006000da47483062a0d734ba3dc7576ce6a0b645c40000000000000000000000005d5577a33abbbae5e7235d2d080caff47e94b7d032a973db4c1e514de62d1b6be157b4c57dbec049a79c1d921439db70785b45000000000000000000000000000000000000000000000000000000000065bbc425000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008573d8281c9a66000000000000000000000000000000000000000000000000005447aea697883a0000000000000000000000005d5577a33abbbae5e7235d2d080caff47e94b7d0",
            "signature": "0x9d6bccaf720382848ae3b6c104fc3312660515bba6a0d15564c9fef31fe479c22443a78aaab730e11497bd8d4183a9aeb1f27af9385911ead334371c04d3f20f1c",
            "input": {
                "endAmount": "100000000",
                "token": "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48",
                "startAmount": "100000000"
            },
            "orderStatus": "open",
            "createdAt": 1706804100,
            "chainId": 1,
            "orderHash": "0xf64a3de305dc00301a5699f61512bddbc12e1ecee3b79e11785489b3e6429be4",
            "type": "Dutch"
        }
    ]
}

Copy link
Contributor

@rileydcampbell rileydcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe in a follow up PR but let's also update the swagger file at some point for integrators.

Copy link

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Generally aligned with Andy's feedback too!

@robert-seitz-uniswap robert-seitz-uniswap force-pushed the add-limit-get branch 2 times, most recently from 7d6a884 to 28c16c4 Compare February 5, 2024 21:21
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a quick look! looking good!

@robert-seitz-uniswap robert-seitz-uniswap merged commit 34bc7df into main Feb 6, 2024
3 checks passed
@robert-seitz-uniswap robert-seitz-uniswap deleted the add-limit-get branch February 6, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants