fix: lowercase getNonce address #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orders are sanitized to have lowercased addresses before pumping into the DB. This means all `offerers` in the nonce db also have lowercased addresses. However, the getNonce query does not do sanitization, so if any integrator requests eip-55 cased nonces, it will not find results in the db. This commit sanitizes However, we should hold out for the frontend to make a fix incrementing the nonce. It's currently relying on nonce randomness to get new nonces
marktoda
force-pushed
the
fix-getNonce-query-address-casing
branch
from
54f03fb to
1d9994a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orders are sanitized to have lowercased addresses before pumping into
the DB. This means all
offerersin the nonce db also have lowercasedaddresses. However, the getNonce query does not do sanitization, so if
any integrator requests eip-55 cased nonces, it will not find results in
the db. This commit sanitizes
However, we should hold out for the frontend to make a fix incrementing
the nonce. It's currently relying on nonce randomness to get new nonces