feat: oracle bridge upgrade on admin networks #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
requested review from
mrice32,
chrismaree,
md0x and
daywiss
as code owners
Reinis-FRP
commented
Apr 14, 2025
| }, | ||
| "devDependencies": { | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "^5.8.3" |
There was a problem hiding this comment.
@safe-global/types-kit was not compatible with older typescipt from the root of the workspace.
Reinis-FRP
commented
Apr 14, 2025
| (e) => | ||
| e.returnValues.calls === | ||
| [{ to: contractsByNetId[network.chainId].registry.options.address, data: registerContractData }] | ||
| const relayedRegisterContractEvent = relayedTransactions.find((e) => |
There was a problem hiding this comment.
The newer typescript version errored to build this as it does not allow comparison of object references
md0x
reviewed
Apr 14, 2025
| data: BytesLike; | ||
| }[] = []; | ||
| const changeImplementationAddressTx = await finder.populateTransaction.changeImplementationAddress( | ||
| ethersUtils.formatBytes32String("Oracle"), |
There was a problem hiding this comment.
nit: use interfaceName.Oracle from
const { interfaceName } = require("@uma/common");
There was a problem hiding this comment.
totally forgot we had it, will fix
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Oracle bridge contract upgrade from #4816 should be rolled out also to admin controlled networks.
Summary
Updates contract deployment address and scripts for generating and verifying multisig payload for upgrading Oracle bridging contracts on admin controlled networks.
Testing
Check a box to describe how you tested these changes and list the steps for reviewers to test.
Issue(s)
Fixes #XXXX