Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS 3141 Add Collection Item Detail query #110

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Feb 7, 2025

Connected to APPS-3141

Page Created: pages / collections / [collectionSlug] / [slug].vue

Notes:

  • Added GraphQL query for Collection Item Details page
  • Loaded preformatted data for testing

Previews:

Checklist:

  • I added github label for semantic versioning
  • I requested a PR review from the Dev team
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • [ ] I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR

@tinuola tinuola added the feature label Feb 7, 2025
@tinuola tinuola self-assigned this Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🚀 Deployed on https://deploy-preview-110--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-110 February 7, 2025 00:11 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-110 February 7, 2025 00:40 Inactive
@tinuola tinuola force-pushed the APPS-3141_collection-item-detail-query branch from e29ccd4 to 467ab3d Compare February 7, 2025 01:12
@github-actions github-actions bot temporarily deployed to pull_request-110 February 7, 2025 01:19 Inactive
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@tinuola tinuola merged commit d1b0c8e into main Feb 7, 2025
12 checks passed
@tinuola tinuola deleted the APPS-3141_collection-item-detail-query branch February 7, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants