Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-3139 Add GQL Query and Create catch all page [...slug].vue #109

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Feb 6, 2025

Connected to APPS-3139

https://deploy-preview-109--test-ftva.netlify.app/about

Currently the AllFtvaFPB has been added.
The image will be updated in Craft and then it will need to be updated here.


Notes:


Page/Pages Created/updated:

  • gql/fragments/BlockInfoFragment.gql
  • gql/fragments/collections/AllFtvaFpb.gql
  • gql/queries/FTVAGeneralContentDetail.gql
  • pages/[...slug].vue

Checklist:

  • I added github label for semantic versioning
  • I double checked it looks like the designs
  • I completed any required mobile breakpoint styling
  • I completed any required hover state styling
  • I included a working spec file
  • I added notes above about how long it took to build this component
  • UX has reviewed this PR
  • I assigned this PR to someone to review

@jendiamond jendiamond self-assigned this Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@jendiamond jendiamond changed the title APPS-3139 Add GQL Query and create catch all page [...slug].vue feat: APPS-3139 Add GQL Query and create catch all page [...slug].vue Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🚀 Deployed on https://deploy-preview-109--test-ftva.netlify.app

@github-actions github-actions bot temporarily deployed to pull_request-109 February 6, 2025 00:45 Inactive
@jendiamond jendiamond changed the title feat: APPS-3139 Add GQL Query and create catch all page [...slug].vue feat: APPS-3139 Add GQL Query and Create catch all page [...slug].vue Feb 6, 2025
@github-actions github-actions bot temporarily deployed to pull_request-109 February 7, 2025 20:48 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-109 February 7, 2025 23:20 Inactive
@jendiamond jendiamond force-pushed the APPS-3139_add-gql-query-and-create-catch-all-slug-page branch from 0860f01 to 8d1a2d2 Compare February 8, 2025 01:15
@github-actions github-actions bot temporarily deployed to pull_request-109 February 8, 2025 01:23 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-109 February 11, 2025 23:27 Inactive
gql/queries/FTVAGeneralContentDetail.gql Outdated Show resolved Hide resolved
gql/queries/FTVAGeneralContentDetail.gql Outdated Show resolved Hide resolved
category="Scategory"
:title="parseTitle"
>
<template #customDescription>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

<template #customTitle>
<rich-text :rich-text-content="page.formattedTitle" />

pages/[...slug].vue Outdated Show resolved Hide resolved
}

if (data.value.entry.slug && process.server) {
const { $elasticsearchplugin } = useNuxtApp()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use a plugin here use the composable we for ftva to index content, check other slug pages in ftva repo


if (data.value.entry.slug && process.server) {
const { $elasticsearchplugin } = useNuxtApp()
await $elasticsearchplugin.index(data.value.entry, path.replaceAll('/', '--'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to call the composable, keep the rest of the arguments passed

>
<NavBreadcrumb
v-if="page"
:title="page.title"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this component, do not pass any props

@@ -0,0 +1,32 @@
// Find all elements with class name "section-header2" or "section-header3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this plugin and add a util named get-headers.js

@github-actions github-actions bot temporarily deployed to pull_request-109 February 12, 2025 01:10 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-109 February 12, 2025 01:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants