-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APPS-3139 Add GQL Query and Create catch all page [...slug].vue #109
base: main
Are you sure you want to change the base?
feat: APPS-3139 Add GQL Query and Create catch all page [...slug].vue #109
Conversation
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/ftva-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
🚀 Deployed on https://deploy-preview-109--test-ftva.netlify.app |
0860f01
to
8d1a2d2
Compare
category="Scategory" | ||
:title="parseTitle" | ||
> | ||
<template #customDescription> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
<template #customTitle>
<rich-text :rich-text-content="page.formattedTitle" />
} | ||
|
||
if (data.value.entry.slug && process.server) { | ||
const { $elasticsearchplugin } = useNuxtApp() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not use a plugin here use the composable we for ftva to index content, check other slug pages in ftva repo
|
||
if (data.value.entry.slug && process.server) { | ||
const { $elasticsearchplugin } = useNuxtApp() | ||
await $elasticsearchplugin.index(data.value.entry, path.replaceAll('/', '--')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to call the composable, keep the rest of the arguments passed
> | ||
<NavBreadcrumb | ||
v-if="page" | ||
:title="page.title" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this component, do not pass any props
@@ -0,0 +1,32 @@ | |||
// Find all elements with class name "section-header2" or "section-header3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this plugin and add a util named get-headers.js
Connected to APPS-3139
https://deploy-preview-109--test-ftva.netlify.app/about
Currently the AllFtvaFPB has been added.
The image will be updated in Craft and then it will need to be updated here.
Notes:
Page/Pages Created/updated:
gql/fragments/BlockInfoFragment.gql
gql/fragments/collections/AllFtvaFpb.gql
gql/queries/FTVAGeneralContentDetail.gql
pages/[...slug].vue
Checklist: