Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same chevron on index #2924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bkeepers
Copy link

@bkeepers bkeepers commented Apr 2, 2025

This is a very minor issue I noticed while working on a custom theme. Most of the site uses chevronDown, but for some reason the index uses chevronSmall. It looks weird when everything is collapsed and they don't match.

Before

image

After

Screenshot 2025-04-02 at 10 37 45 AM

@phoneticallySAARTHaK
Copy link
Contributor

I was wondering the same, but then the index title is also small.

@bkeepers
Copy link
Author

bkeepers commented Apr 3, 2025

I was wondering the same, but then the index title is also small.

Yeah, that's another issue that I was able to fix in my custom template, but I couldn't easily fix the icon being different.

@phoneticallySAARTHaK
Copy link
Contributor

That icon is used only once, IIRC. Better to remove it entirely, and make the icon smaller with CSS if needed, IMO.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 3, 2025

I'd honestly rather have the index size follow the normal hierarchy rules than shrink the size with css - I've just never gotten around to making it do that

@phoneticallySAARTHaK
Copy link
Contributor

I'd honestly rather have the index size follow the normal hierarchy rules than shrink the size with css - I've just never gotten around to making it do that

There's no special CSS targeting index title, It is using an <h5>, which makes it smaller due to default styling.

It would have produced an a11y error due to invalid heading order (as it does for hierarchy), but section "headings" are wrapped in a <summary> element, which has an implicit role of button, which means all content inside it becomes presentational. (MDN)

@bkeepers
Copy link
Author

bkeepers commented Apr 4, 2025

@Gerrit0 Want me to update this to make the index styles consistent?

Below is a screenshot of what I did in my custom theme (the index chevron is still different, but I was able to tweak it enough with CSS to make it less noticeable). If anyone is curious, here's a draft of the site.

image

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 4, 2025

Go for it!

@Gerrit0 Gerrit0 added this to the v0.28.3 milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants