Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to set pod and container security contexts #422

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

explsd
Copy link
Contributor

@explsd explsd commented Mar 18, 2025

In order to run Trow in my cluster, I require extra security context options set. Normally, I would just by just using Helm postrendering, but it doesn't seem like postrendering works with Helm Chart Hooks. So I've added a way to set the security contexts.

The webhook deployment seems to typically use the same options as the statefulset, so that's what I've done here. However, with the same security context as the statefulset, the webhook deployment cannot create the data files it wants to in the default data-dir directoy. In my own deployment, I just set the data-dir to /tmp, but some decision would have to be made before this can be merged in without breaking the webhook deployment.

@explsd explsd requested a review from awoimbee as a code owner March 18, 2025 02:30
Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@awoimbee
Copy link
Collaborator

However, with the same security context as the statefulset, the webhook deployment cannot create the data files [...]

I'll look into this in a another PR before releasing the chart

Co-authored-by: Arthur Woimbée <[email protected]>
@awoimbee awoimbee merged commit c7677ae into Trow-Registry:main Mar 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants