Convert cameras to subsystems, add vision-only pose estimate for pose-seek #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stimate, use it in pose-seek.
…independent-vision-pose-estimation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
Camerais now its own subsystem. Inperiodic(), pipeline results are applied to eachCamera'sPhotonPoseEstimator, and its currentEstimatedRobotPoseis calculated. This pose is also used by theSwerveDrivePoseEstimatorto correct odometry drift as before. The pose-seek logic now usesVision.getEstimatedGlobalPose(), which returns the camera-only pose estimate that has the lowest maximum error component.Needs testing before merging into main.