fix: camera aspect

[andretchen0]

Warning

For current users of <TresOrthographicCamera /> this is a breaking change. A solution is provided but requires intervention. See "Problem 2".

Problem 1

Screen.Recording.2024-02-01.at.20.35.09.mov

Unlike <TresPerspectiveCamera />, <TresOrthographicCamera /> does not update automatically after screen ratio changes.

StackBlitz

Solution

R3F uses the Three.OrthographicCamera's default left, right, top, bottom to maintain the frustum cuboid. This PR follows that example.

---

Problem 2

Tres currently overwrites aspect on <TresPerspectiveCamera />. In rare cases, the user may wish to control aspect.

Similarly, with this PR, left, right, top, bottom on <TresOrthographicCamera /> are controlled by Tres. Users who set those attributes manually need a way to keep Tres from overwriting them.

Solution

R3F lets users set a manual flag on the cameras to opt out of automatic aspect changes. This PR follows that example.

To set a camera as "manual" in TypeScript:

const myCamera = new PerspectiveCamera(); // or OrthographicCamera
(myCamera as any).manual = true

---

Playground

Playground updated at /cameras/camera . manual cameras have been added.

[netlify]

✅ Deploy Preview for tresjs-docs ready!

Name	Link
🔨 Latest commit	722e1ca
🔍 Latest deploy log	https://app.netlify.com/sites/tresjs-docs/deploys/65bc1dc9f7c4f80008cce984
😎 Deploy Preview	https://deploy-preview-531--tresjs-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alvarosabu]

Hey @andretchen0 great work here, thanks for the fix, if it's a breaking change, should we include it better on the v4 then?

[andretchen0]

Hey @andretchen0 great work here, thanks for the fix, if it's a breaking change, should we include it better on the v4 then?

Thanks! v4 is fine with me.

[alvarosabu]

@andretchen0 Ok awesome, just change the base of the PR to the branch v4

[alvarosabu]

@andretchen0 something is off, there are too many changes that weren't related to your initial PR into v4

[andretchen0]

@alvarosabu

Thanks for flagging that.

Merging in v4 seems to have added a lot of files to the PR. I'll close open a new PR that's based on v4 from the start.