feat(datepicker): developing datepicker component #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enes5519
requested changes
Aug 26, 2024
Enes5519
reviewed
Sep 4, 2024
erbilnas
reviewed
Oct 15, 2024
erbilnas
requested changes
Oct 15, 2024
|
We should also separate the calendar tests from the date picker since it’s a different subject that should be addressed in a separate merge request |
AykutSarac
reviewed
Oct 22, 2024
AykutSarac
reviewed
Oct 22, 2024
src/mixins/datepicker-calendar-mixin/datepicker-calendar-mixin.ts
Outdated
Show resolved
Hide resolved
erbilnas
previously approved these changes
Oct 30, 2024
|
@dilandoogan we should resolve conflict first |
Enes5519
requested changes
Nov 7, 2024
| * Defines the unselectable dates for calendar | ||
| */ | ||
| @property({ type: Array, attribute: "disabled-dates", reflect: true }) | ||
| disabledDates: Date[]; |
There was a problem hiding this comment.
buraya custom parser yazalım her zaman Date array dönebilmesi için
Enes5519
reviewed
Nov 7, 2024
| @@ -79,7 +79,7 @@ export default class BlPopover extends LitElement { | |||
| /** | |||
| * Visibility state | |||
| */ | |||
| @state() private _visible = false; | |||
| @state() _visible = false; | |||
There was a problem hiding this comment.
getter ve setter'ları bulunuyor bunu private'den çıkarmayalım ustam
Enes5519
reviewed
Nov 7, 2024
| event.preventDefault(); | ||
| }); | ||
|
|
||
| document.addEventListener("mousedown", event => { |
There was a problem hiding this comment.
inputEl ve calendarEl'e aynı listener geçerek buradaki maliyetten çıkabilir miyiz?
There was a problem hiding this comment.
çıkamıyorsak daha sonrasında listener kalkmalı
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.