Extend windows(-core) dependency range to 0.57-0.61
#34
+35
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
changed the title
windows(-core) crate range to 0.57-0.60windows(-core) crate range to 0.57-0.61
MarijnS95
changed the title
windows(-core) crate range to 0.57-0.61windows(-core) crate range to 0.57-0.61
The generated code now uses `Ref` in native symbol definitions, which is already used in all member functions; unfortunately all Windows code uses `transmute_copy()` to construct this but it does show that we didn't/don't really need to consume ownership of the `device: IUnknown` (previously leaked when passed as a `device.clone()` to a native function that doesn't "consume ownership" of the pointer). We can remove the heavy checked-in `Windows.Win32.winmd` which has been available behind `--in default` in `bindings.txt` for a while. Finally, take this chance to update our `WinmdGenerator` tooling and Windows SDK version. https://github.com/microsoft/windows-rs/releases/tag/0.62.0 https://github.com/microsoft/windows-rs/releases/tag/63
MarijnS95
changed the title
windows(-core) crate range to 0.57-0.61windows(-core) dependency range to 0.57-0.61
Athosvk
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code now uses
Refin native symbol definitions, which is already used in all member functions; unfortunately all Windows code usestransmute_copy()to construct this but it does show that we didn't/don't really need to consume ownership of thedevice: IUnknown(previously leaked when passed as adevice.clone()to a native function that doesn't "consume ownership" of the pointer).We can remove the heavy checked-in
Windows.Win32.winmdwhich has been available behind--in defaultinbindings.txtfor a while.Finally, take this chance to update our
WinmdGeneratortooling and Windows SDK version.https://github.com/microsoft/windows-rs/releases/tag/0.62.0
https://github.com/microsoft/windows-rs/releases/tag/63