[ZH] Fix: Invalid memory access in AudioManager::addAudioEvent #464

Author: xezon

Diff for: GeneralsMD/Code/GameEngine/Include/Common/GameAudio.h

@@ -262,7 +262,7 @@ class AudioManager : public SubsystemInterface
 		const MiscAudio *getMiscAudio( void ) const;
 
 		// This function should only be called by AudioManager, MusicManager and SoundManager
-		virtual void releaseAudioEventRTS( AudioEventRTS *eventToRelease );
+		virtual void releaseAudioEventRTS( AudioEventRTS *&eventToRelease );
 
 		// For INI
 		AudioSettings *friend_getAudioSettings( void );

Diff for: GeneralsMD/Code/GameEngine/Include/Common/GameSounds.h

@@ -69,7 +69,7 @@ class SoundManager : public SubsystemInterface
 		virtual void setCameraAudibleDistance( Real audibleDistance );
 		virtual Real getCameraAudibleDistance( void );
 
-		virtual void addAudioEvent(AudioEventRTS *eventToAdd);	// pre-copied
+		virtual void addAudioEvent(AudioEventRTS *&eventToAdd);	// pre-copied
 
 		virtual void notifyOf2DSampleStart( void );
 		virtual void notifyOf3DSampleStart( void );

Diff for: GeneralsMD/Code/GameEngine/Source/Common/Audio/GameAudio.cpp

@@ -1090,7 +1090,7 @@ AudioHandle AudioManager::allocateNewHandle( void )
 }
 
 //-------------------------------------------------------------------------------------------------
-void AudioManager::releaseAudioEventRTS( AudioEventRTS *eventToRelease )
+void AudioManager::releaseAudioEventRTS( AudioEventRTS *&eventToRelease )
 {
 	if( eventToRelease )
 	{

Diff for: GeneralsMD/Code/GameEngine/Source/Common/Audio/GameSounds.cpp

@@ -136,7 +136,7 @@ Real SoundManager::getCameraAudibleDistance( void )
 }
 
 //-------------------------------------------------------------------------------------------------
-void SoundManager::addAudioEvent(AudioEventRTS *eventToAdd)
+void SoundManager::addAudioEvent(AudioEventRTS *&eventToAdd)
 {
 	if (m_num2DSamples == 0 && m_num3DSamples == 0) {
 		m_num2DSamples = TheAudio->getNum2DSamples();