Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the cluster configuration #26

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Added the cluster configuration #26

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e06244
Added the cluster configuration
eitangol Feb 5, 2025
9fc86e9
CR FIXES
eitangol Feb 5, 2025
c9750a5
Update values.yaml
eitangol Feb 5, 2025
197cbf6
Update values.schema.json
eitangol Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion charts/lunar-proxy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,15 @@ spec:
- name: LUNAR_RETRY_REQUEST_TIMEOUT_SEC
value: {{ toString .Values.timeouts.retryRequestTimeoutSec | quote }}
{{- end }}

# Lunar Cluster
{{- if .Values.lunarCluster.lunarClusterStaleThresholdPeriodInSec }}
- name: LUNAR_CLUSTER_STALE_THRESHOLD_PERIOD_IN_SEC
value: {{ toString .Values.lunarCluster.lunarClusterStaleThresholdPeriodInSec | quote }}
{{- end }}
{{- if .Values.lunarCluster.lunarClusterLivenessUpdatedPeriodInSec }}
- name: LUNAR_CLUSTER_LIVENESS_UPDATED_PERIOD_IN_SEC
value: {{ toString .Values.lunarCluster.lunarClusterLivenessUpdatedPeriodInSec | quote }}
{{- end }}
# Redis
{{- if .Values.redis.url }}
- name: REDIS_URL
Expand Down
12 changes: 8 additions & 4 deletions charts/lunar-proxy/values.yaml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update values.schema.json as well

Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ podAnnotations: {}

metrics:
datadog:
enabled: false # Users can set this to true to enable Datadog metrics collection
namespace: "lunar_proxy" # Default namespace for metrics; users can override as needed
enabled: false # Users can set this to true to enable Datadog metrics collection
namespace: "lunar_proxy" # Default namespace for metrics; users can override as needed
includedMetrics: # List of metrics to collect; default is all metrics
- ".*"

- ".*"

lunarAPIKey: null # Set the API key directly
lunarAPIKeySecretName: null # Set the API key from a secret (key must be named lunarAPIKey)
Expand All @@ -35,6 +34,11 @@ lunarHubURL: null
telemetryEnabled: true
lunarManaged: false

# Lunar Cluster configuration
lunarCluster:
lunarClusterStaleThresholdPeriodInSec: 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lunarClusterStaleThresholdPeriodInSec: 120
staleThresholdPeriodInSec: 120

You already created a parent field lunarCluster, don't repeat

lunarClusterLivenessUpdatedPeriodInSec: 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no problem, just considering that the default expire time is 2 min


# Redis configuration
redis:
prefix: "lunar"
Expand Down