Remove ArrayDef macro and cleanup of Make_Global

[duncanspumpkin]

I used a regex to find/replace the ArrayDefs with the equivalent Make_Global code.
I also noticed that two users of Make_Global were from a very old version where a macro was used for the identifier name. I've brought those into normal alignment.
One item of note whilst doing this is that we have a handful of Make_Globals outside of the setupglobals file.
Unsure if they should all be moved into setupglobals.

[xezon]

Hmm. To be fair it actually looks nicer to look at with the macros. The duplication of types and array sizes is quite a strain when typing it out by hand. Maybe we can just leave it as is.

[duncanspumpkin]

Hmm. To be fair it actually looks nicer to look at with the macros. The duplication of types and array sizes is quite a strain when typing it out by hand. Maybe we can just leave it as is.

For the make globals you can get rid of the left hand side and replace with auto& to reduce the duplication. I'm not overly fussed either way it is done this doesn't exactly represent much work

[xezon]

Yes auto could be ok here, because the type is already written on the right side.

auto &g_waterSettings = Make_Global<WaterSetting[TIME_OF_DAY_COUNT]>(PICK_ADDRESS(0x00A2F0B8, 0x00A2F0B8));

Will this compile?

[duncanspumpkin]

Yes auto could be ok here, because the type is already written on the right side.

auto &g_waterSettings = Make_Global<WaterSetting[TIME_OF_DAY_COUNT]>(PICK_ADDRESS(0x00A2F0B8, 0x00A2F0B8));

Will this compile?

Yes that should compile.

[duncanspumpkin]

After further testing I can confirm it would compile but only if we didn't forward declare so basically we can't do it that way.

[OmniBlade]

@duncanspumpkin Looks like CI checks are broken, once its passing the CI I'll merge this.

[duncanspumpkin]

Even with how much of a mouthful the definition ends up being?

[OmniBlade]

We could keep definitions macros just to keep some of the duplicate type and size declarations to a minimum? At least we don't need the helper structs anymore.

[duncanspumpkin]

We could keep definitions macros just to keep some of the duplicate type and size declarations to a minimum? At least we don't need the helper structs anymore.

The helper struct was removed in the other PR this was just removing the macros. Tbh I'm not sure if there is much merrit in this PR it ends up being so verbose its annoying that auto can't come to our rescue for this.