add support for MinGW32 compiler #9
Open
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Gamez <[email protected]>
OmniBlade
reviewed
Mar 24, 2025
| @@ -1706,7 +1706,11 @@ static void GenerateID(char* keyval) | |||
| LARGE_INTEGER l1; | |||
| UINT seed; | |||
| if (QueryPerformanceCounter(&l1)) | |||
| #ifdef __MINGW32__ | |||
There was a problem hiding this comment.
Don't gate this change behind just mingw, it should work for msvc as well.
OmniBlade
reviewed
Mar 24, 2025
| { \ | ||
| if (l < sizeof(TYPE)) \ | ||
| return -1; \ | ||
| TYPE temp = va_arg(*args, TYPE); \ |
There was a problem hiding this comment.
Again no need to gate this behind mingw, but it would need fixing to C89 standards, so TYPE temp; needs to go at the top of the scope. A better fix is just to add || defined(__MINGW32__) next to the || defined(_X360) above IMO though as it seems MINGW should take the same path as the _UNIX define does.
OmniBlade
requested changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling gamespy on MinGW32 a issue is encountered
gt2encode.c
gsplatformutil.c
Changes
Add makro dedection for MinGW compiler.
Vision
This is work for the ability to crosscompile ZH from linux to windows and in the future produce a native binary aswell.