Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8: Drop ignore of issue A003 #7949

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Nov 2, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 2, 2022
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I prefer attributes such as next and prev to next_ and prev_
Especially when it comes to set and put, because they are different concepts.
I don't see a problem with globally ignoring A003

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 2, 2022
@cclauss cclauss merged commit 45b3383 into TheAlgorithms:master Nov 2, 2022
@cclauss cclauss deleted the drop-flake8-A003 branch November 2, 2022 18:20
@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 2, 2022

@cclauss I agree with @CaedenPH on this and was discussed earlier as well. A003 is a false positive and is supposedly going to be disabled by default in the plugin itself. I suggest to revert this change.

@cclauss
Copy link
Member Author

cclauss commented Nov 2, 2022

@gforcada Your sense of this pull request? Does A003 generate false positives? Should we revert?

@TheAlgorithms TheAlgorithms deleted a comment from dhruvmanila Nov 4, 2022
@gforcada
Copy link

gforcada commented Nov 4, 2022

If my opinion is asked, here is is given 😄 : I very much prefer to keep A003 enabled on the plugin itself, and let each user decide if it's useful or not. For my projects I very much prefer not to use builtins even on A003 cases, that my personal preference. Fortunately flake8 has a powerful configuration system and you probably are already configuring some bits of it anyway. I will not get offended if someone ignores A003 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants