Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Miller Rabin Primality Test #1321

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sundaram123krishnan
Copy link

@sundaram123krishnan sundaram123krishnan commented May 4, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@sundaram123krishnan
Copy link
Author

someone help with indentation pls , thx in advance

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Try adding more comments to the code (but do not add redundant comments).
  • Add tests.
  • What are the changes to package.json and package-lock.json for? They look accidental to me.

@appgurueu
Copy link
Collaborator

someone help with indentation pls , thx in advance

You should be able to simply run https://standardjs.com/ against your code.

@sundaram123krishnan
Copy link
Author

yaa actually i had added npm format package

@sundaram123krishnan
Copy link
Author

now it works, thx

@sundaram123krishnan
Copy link
Author

deleted

@sundaram123krishnan
Copy link
Author

any further changes to be done ? @appgurueu

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing tests and comments. For example you use exponentation by squaring, but don't explain this using comments. Also still contains the unrelated package[-lock].json changes.

@sundaram123krishnan
Copy link
Author

should i add more comments explaining this algorithm?

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants