Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added algorithm CheckHeterogram #1221

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added algorithm CheckHeterogram #1221

wants to merge 3 commits into from

Conversation

KevinLindh
Copy link

@KevinLindh KevinLindh commented Oct 21, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Oct 21, 2022
View reviewed changes
@KevinLindh
Removed unnecessary variable assignment from tests
97f4bdf 
Thank you for noticing this unnecessary piece of code. I tried to see how others wrote the tests but in this case, assigning something that immediately gets compared is an extra step that doesn't make a difference.
@KevinLindh
Changed solution of algorithm from regex to hashmap
fb736de
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu left review comments

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
stale Closed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinLindh @appgurueu