Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the PR template #1213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs: improve the PR template #1213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3573c20
Updated Documentation in README.md
Oct 17, 2022
f78f8d6
docs: improve the PR template
Panquesito7 Oct 19, 2022
9498976
Merge branch 'master' into improve_pr_template
Panquesito7 Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/) [know more](https://www.gitpod.io/docs/pull-requests/)

### Describe your change:
### Describe your change

- [ ] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
- [ ] Miscellaneous changes? <!-- Please explain your changes below. See the following example. -->

<!-- Remove the issue number section if applicable.

- Fix the `DIRECTORY.md` workflow from not committing changes.
- Closes #{$ISSUE_NO}
-->

### Checklist:
<!--
### Checklist

- [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md).
- [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/JavaScript/blob/master/CONTRIBUTING.md).
- [ ] This pull request is all my own work -- I have not plagiarized.
- [ ] I know that pull requests will not be merged if they fail the automated tests.
- [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [ ] All new JavaScript files are placed inside an existing directory.
- [ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
**Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not
- [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.
- **Example:** `UserProfile.js` is allowed but `userprofile.js`, `Userprofile.js`, `user-Profile.js`, and `userProfile.js` are not.
- [ ] All new algorithms have a URL in their comments that points to Wikipedia or similar explanations.
- [ ] If this pull request resolves one or more open issues, add `Closes: #{$ISSUE_NO}` to this PR.
-->