Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilyasse #5451

Closed
wants to merge 3 commits into from
Closed

Ilyasse #5451

wants to merge 3 commits into from

Conversation

ilyasseyounes1
Copy link

@ilyasseyounes1 ilyasseyounes1 commented Sep 16, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.07%. Comparing base (6f52114) to head (3d160e7).
Report is 124 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #5451       +/-   ##
=============================================
+ Coverage     41.53%   52.07%   +10.53%     
- Complexity     2557     3240      +683     
=============================================
  Files           520      524        +4     
  Lines         15426    15181      -245     
  Branches       2947     2888       -59     
=============================================
+ Hits           6407     7905     +1498     
+ Misses         8725     6954     -1771     
- Partials        294      322       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm
Copy link
Contributor

alxkm commented Sep 16, 2024

Provided empty spaces were not matching with project checkstyle rules. And are useless in contribution context.
Also redundant empty files.

@alxkm alxkm closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants