Data structures/queue using array2.cpp #2923
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update a queue
fixes #2690
Issues in your code:
Deque() causes incorrect shifting
The shifting logic in Deque() is incorrect.
Instead of shifting all elements and updating rear, use front to track the front element.
Incorrect Underflow condition
If front == rear, the queue is empty, but you still proceed with shifting.
Hardcoded queue size (10)
You are not handling a circular queue approach, which is more efficient for queues.
Loop exits incorrectly in main()
The loop should have an explicit exit condition (0 isn't handled)