Fix/console.print failed to render weakref.proxy objects #3684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3656
Title: Improve Rich's Pretty Inspection to Handle Weakref Proxies Gracefully
Description:
This PR enhances Rich's inspection system by adding explicit handling for
weakref.proxy
objects in thesafe_repr
function. It preventsReferenceError
exceptions when inspecting dead weakref proxies and ensures consistent output formatting.Key Changes:
safe_repr
.object.__getattribute__(obj, "__callback__")
, avoiding accidental forwarding.<weakproxy ...; dead>
when the reference is broken.Pretty
class to use the modifiedsafe_repr
function.weakref.ref
handling.Benefits:
✅ Prevents
ReferenceError
when inspecting dead weakref proxies.✅ Matches Python's native
weakref.ref
behavior.✅ Provides detailed output for alive proxies while marking dead ones explicitly.
✅ Ensures better debugging experience when dealing with weak references.
Verification: