Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slowdown during death animation #1195

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

InfoTeddy
Copy link
Contributor

Some discussion on the Discord server resulted in this change. It's a quality-of-life improvement where, if the game is in slowdown mode, it will return to 100% speed for the duration of the death animation.

The reasoning is obvious. There is nothing to do during the death animation, so making it take longer during slowdown is just an annoyance to the player, almost a penalty for them using an accessibility option. This is the same reason why slowdown no longer applies in menus, etc.

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes unless there is a prior written agreement

@InfoTeddy InfoTeddy self-assigned this Sep 16, 2024
Copy link
Contributor

@Daaaav Daaaav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Slowdown certainly feels much better this way.

Some discussion on the Discord server resulted in this change. It's a
quality-of-life improvement where, if the game is in slowdown mode, it
will return to 100% speed for the duration of the death animation.

The reasoning is obvious. There is nothing to do during the death
animation, so making it take longer during slowdown is just an annoyance
to the player, almost a penalty for them using an accessibility option.
This is the same reason why slowdown no longer applies in menus, etc.
@InfoTeddy InfoTeddy force-pushed the general-improvements-3 branch from 115637c to e2fc606 Compare September 26, 2024 04:10
@InfoTeddy InfoTeddy merged commit c870df4 into TerryCavanagh:master Sep 26, 2024
3 checks passed
@InfoTeddy InfoTeddy deleted the general-improvements-3 branch September 26, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants