Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: address IntelliJ QAPlug plugin findings #75

Merged
merged 3 commits into from
Dec 10, 2023
Merged

refactor: address IntelliJ QAPlug plugin findings #75

merged 3 commits into from
Dec 10, 2023

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Oct 22, 2023 •
edited
Loading

  • make final fields static
  • remove unnecessary if statement nesting
  • remove unused local variables

Relates to MovingBlocks/Terasology#5149

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance labels Oct 22, 2023
@jdrueckert jdrueckert mentioned this pull request Oct 22, 2023
Merged
jdrueckert added a commit to MovingBlocks/Terasology that referenced this pull request Nov 11, 2023
@jdrueckert
refactor: address IntelliJ QAPlug plugin findings (#5149)
1cef7c1 
* make final fields static
* remove unnecessary local before return
* remove instanceof checks in catch clause
* avoid throwing java.lang.Exception
* remove null checks covered by instanceof check
* remove toString on String objects
* remove overrides that only call their super
* remove unused private methods
* remove unnecessary if statement nesting
* remove unused local variables
* use try-with-resources to close resources after use
* use equals() to compare object references
* fix broken javadoc references
* fix disallowed self-closing and empty javadoc elements
* fix bad use of symbols in javadoc
* fix disallowed list item tag in javadoc without surrounding list
* fix erroneous javadoc tags
* fix emphasize tags in javadoc
* remove illegal throws
* remove unused imports

Related:
Terasology/CoreRendering#75
Terasology/Furnishings#17
Terasology/Health#105
Terasology/Inventory#51
Terasology/Behaviors#114
Terasology/CoreWorlds#45
Terasology/FlexiblePathfinding#32

Adds to #3859
@soloturn soloturn merged commit b01eb17 into develop Dec 10, 2023
11 checks passed
@soloturn soloturn deleted the chore/qaplug-findings branch December 17, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloturn soloturn soloturn approved these changes

Assignees
No one assigned
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @soloturn