-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.0.6 #30
release: v0.0.6 #30
Conversation
Reviewer's Guide by SourceryThis pull request updates the HTML template for displaying advertisement images and bumps the version to v0.0.6. It also removes the Class diagram showing template.py changesclassDiagram
class Template {
+List[str] adivertisement_images
+str html()
}
note for Template "Changed html() method to use
fixed layout for advertisement images
instead of dynamic generation"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tohrusky - I've reviewed your changes - here's some feedback:
Overall Comments:
- The HTML template now assumes exactly 3 advertisement images. Consider making this more flexible to handle varying numbers of images to prevent potential runtime errors.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -68,7 +68,6 @@ you should provide the compatible params and scripts in the [params](./conf/para | |||
- [httpx](https://github.com/encode/httpx) | |||
- [qbittorrent](https://github.com/qbittorrent/qBittorrent) | |||
- [qbittorrent-api](https://github.com/rmartin16/qbittorrent-api) | |||
- [telegram-bot-api](https://github.com/tdlib/telegram-bot-api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Removed telegram-bot-api
dependency: Check for any remaining references in the documentation.
Since the telegram-bot-api
dependency has been removed, ensure that there are no remaining references to it elsewhere in the documentation. Please also note that the link to the repository seems incorrect; it should be https://github.com/eternnoir/pyTelegramBotAPI
, although this is less relevant now that the dependency is removed.
feat: update html template
Summary by Sourcery
New Features: