Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.0.6 #30

Merged
merged 2 commits into from
Jan 3, 2025
Merged

release: v0.0.6 #30

merged 2 commits into from
Jan 3, 2025

Conversation

Tohrusky
Copy link
Member

@Tohrusky Tohrusky commented Jan 3, 2025

feat: update html template

Summary by Sourcery

New Features:

  • Display advertisement images with a new layout in the generated HTML.

Copy link

sourcery-ai bot commented Jan 3, 2025

Reviewer's Guide by Sourcery

This pull request updates the HTML template for displaying advertisement images and bumps the version to v0.0.6. It also removes the telegram-bot-api dependency.

Class diagram showing template.py changes

classDiagram
    class Template {
        +List[str] adivertisement_images
        +str html()
    }
    note for Template "Changed html() method to use
fixed layout for advertisement images
instead of dynamic generation"
Loading

File-Level Changes

Change Details Files
Updated the advertisement image display in the HTML template.
  • Replaced the previous image display with a new layout that features one large image at the top and two smaller images side-by-side below it.
  • Adjusted image widths to improve the visual presentation.
animepipeline/template/template.py
Bumped the project version.
  • Updated the version number from 0.0.5 to 0.0.6 in the pyproject.toml file.
pyproject.toml
Removed the telegram-bot-api dependency.
  • Deleted the telegram-bot-api entry from the list of dependencies in the README file.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tohrusky - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The HTML template now assumes exactly 3 advertisement images. Consider making this more flexible to handle varying numbers of images to prevent potential runtime errors.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -68,7 +68,6 @@ you should provide the compatible params and scripts in the [params](./conf/para
- [httpx](https://github.com/encode/httpx)
- [qbittorrent](https://github.com/qbittorrent/qBittorrent)
- [qbittorrent-api](https://github.com/rmartin16/qbittorrent-api)
- [telegram-bot-api](https://github.com/tdlib/telegram-bot-api)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Removed telegram-bot-api dependency: Check for any remaining references in the documentation.

Since the telegram-bot-api dependency has been removed, ensure that there are no remaining references to it elsewhere in the documentation. Please also note that the link to the repository seems incorrect; it should be https://github.com/eternnoir/pyTelegramBotAPI, although this is less relevant now that the dependency is removed.

@Tohrusky Tohrusky merged commit 6d03b30 into TensoRaws:main Jan 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant