Support CMYK color space for JPG images and fix the crash issues. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingpqi123
requested review from
domchen,
Hparty and
shlzxjp
as code owners
domchen
reviewed
Jan 14, 2025
| @@ -180,6 +205,13 @@ bool JpegCodec::readPixels(const ImageInfo& dstInfo, void* dstPixels) const { | |||
| } | |||
| result = jpeg_finish_decompress(&cinfo); | |||
| } while (false); | |||
| if (cinfo.out_color_space == JCS_CMYK) { | |||
| int count = dstInfo.width() * dstInfo.height(); | |||
There was a problem hiding this comment.
这里不能用宽乘以高就作为size来遍历，rowBytes可能不等于宽度。
domchen
reviewed
Jan 14, 2025
| @@ -108,6 +108,28 @@ std::shared_ptr<ImageCodec> JpegCodec::MakeFromData(const std::string& filePath, | |||
| orientation, filePath, std::move(byteData))); | |||
| } | |||
|
|
|||
| bool CMYKToColorType(uint32_t* dst, const uint32_t* src, int count, ColorType type) { | |||
There was a problem hiding this comment.
研究一下skcms那个第三方库有没有自带cmyk到其他格式的转换，用那个库的实现性能更好，有串行指令优化。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.