This repository has been archived by the owner on May 13, 2024. It is now read-only.
feat: import of existing resources #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akselleirv
requested review from
nikolaifa,
WilliamDahlen and
kristian-schjelderup
akselleirv
had a problem deploying
to
terraform-test
GitHub Actions
Failure
akselleirv
temporarily deployed
to
terraform-test
GitHub Actions
Inactive
WilliamDahlen
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import of existing resources was not possible as the eligibility requests id was impossible/difficult to find.
I took inspiration from the azurerm provider and implemented the import with the use of combining the scope and principal id. The read method now uses the list endpoint and filters for those two values.