feat: Aside 컴포넌트 퍼블리싱 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubinquitous
approved these changes
Mar 7, 2024
Comment on lines
+5
to
+7
| "M2.22233 1.17949L10.6479 9.57893C10.7479 9.67892 10.8186 9.78725 10.8599 9.90391C10.9019 10.0206 10.9229 10.1456 10.9229 10.2789C10.923 10.4122 10.902 10.5372 10.86 10.6539C10.8186 10.7706 10.748 10.8789 10.648 10.9789L2.22356 19.4045C1.99024 19.6378 1.69858 19.7545 1.34858 19.7546C0.998584 19.7546 0.698576 19.6296 0.448559 19.3796C0.198542 19.1296 0.0735227 18.838 0.0735002 18.5046C0.0734777 18.1713 0.198458 17.8796 0.448441 17.6296L7.79794 10.2791L0.447449 2.92961C0.2141 2.69629 0.0974137 2.40897 0.0973907 2.06764C0.0973676 1.72564 0.222348 1.42963 0.472331 1.17961C0.722314 0.929594 1.01397 0.804574 1.34731 0.804552C1.68064 0.804529 1.97231 0.929509 2.22233 1.17949Z", | ||
| down: "M16.7751 22.7249C16.5433 22.9562 16.3594 23.231 16.234 23.5334C16.1085 23.8358 16.0439 24.16 16.0439 24.4874C16.0439 24.8149 16.1085 25.1391 16.234 25.4415C16.3594 25.7439 16.5433 26.0187 16.7751 26.2499L28.2501 37.7249C28.4813 37.9567 28.7561 38.1406 29.0585 38.266C29.3609 38.3915 29.6851 38.4561 30.0126 38.4561C30.34 38.4561 30.6642 38.3915 30.9666 38.266C31.2691 38.1406 31.5438 37.9567 31.7751 37.7249L43.2501 26.2499C43.4815 26.0185 43.6651 25.7437 43.7904 25.4413C43.9156 25.1389 43.9801 24.8148 43.9801 24.4874C43.9801 24.1601 43.9156 23.836 43.7904 23.5336C43.6651 23.2312 43.4815 22.9564 43.2501 22.7249C43.0186 22.4935 42.7438 22.3099 42.4414 22.1846C42.139 22.0594 41.8149 21.9949 41.4876 21.9949C41.1602 21.9949 40.8361 22.0594 40.5337 22.1846C40.2313 22.3099 39.9565 22.4935 39.7251 22.7249L30.0001 32.4249L20.3001 22.7249C19.3251 21.7749 17.7251 21.7749 16.7751 22.7249Z", | ||
| left: "M8.773 19.3793L0.347998 10.9793C0.247998 10.8793 0.177331 10.771 0.135998 10.6543C0.093998 10.5377 0.072998 10.4127 0.072998 10.2793C0.072998 10.146 0.093998 10.021 0.135998 9.90432C0.177331 9.78766 0.247998 9.67932 0.347998 9.57932L8.773 1.15432C9.00633 0.920988 9.298 0.804321 9.648 0.804321C9.998 0.804321 10.298 0.929321 10.548 1.17932C10.798 1.42932 10.923 1.72099 10.923 2.05432C10.923 2.38765 10.798 2.67932 10.548 2.92932L3.198 10.2793L10.548 17.6293C10.7813 17.8627 10.898 18.15 10.898 18.4913C10.898 18.8333 10.773 19.1293 10.523 19.3793C10.273 19.6293 9.98133 19.7543 9.648 19.7543C9.31466 19.7543 9.023 19.6293 8.773 19.3793Z", |
There was a problem hiding this comment.
제가 방향을 헷갈려서 실수했네요 ㅎㅎ.. 잘 수정해주셔서 감사합니당
components/Aside/index.tsx
Outdated
Comment on lines
13
to
15
| <a className={styles.docsName} href="/"> | ||
| 한예준(학생) | ||
| </a> |
There was a problem hiding this comment.
a태그를 사용하신 이유가 있을까요? next/link 태그를 사용해보시는건 어떨까요?
There was a problem hiding this comment.
Next/link를 까먹었네요
수정하였습니다!
components/Aside/index.tsx
Outdated
| <a className={styles.docsName} href="/"> | ||
| 한예준(학생) | ||
| </a> | ||
| <span className={styles.docsLastModified}> 3시간 전</span> |
There was a problem hiding this comment.
margin을 사용하지 않고 간격을 벌이기 위해서 했는데 코드 가독성이 떨어지는 것 같아 수정하였습니다!
components/Aside/index.tsx
Outdated
| width={11} | ||
| height={11} | ||
| viewBox="0 0 11 20" | ||
| fill="#274168" |
There was a problem hiding this comment.
theme에 지정되어있는 thene.primary를 사용해보시는것도 좋을 것 같아요!
components/Aside/index.tsx
Outdated
| width={11} | ||
| height={11} | ||
| viewBox="0 0 11 20" | ||
| fill="#274168" |
There was a problem hiding this comment.
이하동일합니다!
추가적으로 viewBox는 따로 지정해주지 않으면 화살표가 잘리는 문제가 발생하는지도 궁금합니다!
There was a problem hiding this comment.
viewBox를 지정해주지 않으면 ArrowIcon의 크기가 너무 작아지거나 잘리는 문제가 발생해서 지정하였습니다!
There was a problem hiding this comment.
이해했습니다! 추가적으로 사용할때 유의하겠습니다 ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close #9
What
Aside 컴포넌트를 퍼블리싱하였습니다.
How
ScreenShot