Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs content container should take up available height #263

Merged
merged 2 commits into from
Aug 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/DocsLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
useMatches,
useNavigate,
useParams,
useRouterState,

Check warning on line 15 in app/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'useRouterState' is defined but never used
} from '@tanstack/react-router'
import type { AnyOrama, SearchParamsFullText, AnyDocument } from '@orama/orama'
import { SearchBox, SearchButton } from '@orama/searchbox'

Check warning on line 18 in app/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'SearchButton' is defined but never used
import { Carbon } from '~/components/Carbon'
import { Select } from '~/components/Select'
import { useLocalStorage } from '~/utils/useLocalStorage'
Expand All @@ -25,7 +25,7 @@
import type { ConfigSchema, MenuItem } from '~/utils/config'
import { create } from 'zustand'
import { searchBoxParams, searchButtonParams } from '~/components/Orama'
import { Framework, getFrameworkOptions, getLibrary } from '~/libraries'

Check warning on line 28 in app/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

'getLibrary' is defined but never used
import { DocsCalloutQueryGG } from '~/components/DocsCalloutQueryGG'
import { DocsCalloutBytes } from '~/components/DocsCalloutBytes'
import { ClientOnlySearchButton } from './ClientOnlySearchButton'
Expand Down Expand Up @@ -539,7 +539,7 @@
{largeMenu}
<div
className={twMerge(
`max-w-full min-w-0 min-h-0 flex relative justify-center w-full`,
`max-w-full min-w-0 flex relative justify-center w-full min-h-[88dvh] lg:min-h-0`,
!isExample && 'mx-auto w-[900px]'
)}
>
Expand Down Expand Up @@ -610,7 +610,7 @@
key={partner.name}
className="overflow-hidden hover:bg-gray-500/10 dark:hover:bg-gray-500/10 transition-colors"
>
<a

Check warning on line 613 in app/components/DocsLayout.tsx

View workflow job for this annotation

GitHub Actions / PR

Using target="_blank" without rel="noreferrer" (which implies rel="noopener") is a security risk in older browsers: see https://mathiasbynens.github.io/rel-noopener/#recommendations
href={partner.href}
target="_blank"
className="px-4 flex items-center justify-center cursor-pointer"
Expand Down
Loading